SmartSprites
  1. SmartSprites
  2. SMARTSPRITES-83

csssprites.org says the default value for sprite-layout is horizontal, but it is actually vertical

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.2.8
    • Fix Version/s: 0.2.9
    • Labels:

      Description

      The documentation on csssprites.org says the default value for sprite-layout is horizontal, but when running the latest release it seems vertical is the actual default.

        Activity

        Hide
        Stanisław Osiński added a comment -

        Fixed in HEAD.

        Show
        Stanisław Osiński added a comment - Fixed in HEAD.
        Hide
        Ron Gross added a comment -

        Wait ... what is the fix, changing the default value?
        Won't this break a lot of sites that rely on it? I assumed that the fix would be fixing the documentation, not the code.

        Show
        Ron Gross added a comment - Wait ... what is the fix, changing the default value? Won't this break a lot of sites that rely on it? I assumed that the fix would be fixing the documentation, not the code.
        Hide
        Stanisław Osiński added a comment -

        The fix is in the documentation (https://github.com/carrotsearch/smartsprites/commit/56ea136d4c598ebecbce06ec0e3e3272de7966ef), which is also part of the repository. The comment I made on this issue may have been misleading though.

        Show
        Stanisław Osiński added a comment - The fix is in the documentation ( https://github.com/carrotsearch/smartsprites/commit/56ea136d4c598ebecbce06ec0e3e3272de7966ef ), which is also part of the repository. The comment I made on this issue may have been misleading though.
        Hide
        Ron Gross added a comment -

        Alright, thanks for clarifying this.

        Show
        Ron Gross added a comment - Alright, thanks for clarifying this.

          People

          • Assignee:
            Stanisław Osiński
            Reporter:
            Ron Gross
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development