Issue Details (XML | Word | Printable)

Key: SMARTSPRITES-54
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Stanisław Osiński
Reporter: Ibrahim Chaehoi
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
SmartSprites

Css Attribute parsing : handle url with semi colon

Created: 21/Sep/09 11:54 PM   Updated: 22/Sep/09 09:07 PM   Resolved: 22/Sep/09 07:53 PM
Component/s: None
Affects Version/s: 0.2.4
Fix Version/s: 0.2.5

Time Tracking:
Original Estimate: 2h
Original Estimate - 2h
Remaining Estimate: 0h
Remaining Estimate - 0h
Time Spent: 0h 10m
Time Spent - 0h 10m Time Not Required

File Attachments: 1. File CssSyntaxUtils.diff (0.5 kB)



 Description  « Hide

Hi Staszek,

I've found one issue in the CSS attribute parsing.
Smartsprites can't handle image URL declaration where the is a semi colon in the URL like below :

background-image : url('http://issues.carrot2.org/s/302/1/_/images/carrot2-clustering-engine.gif")
background-image : url('jar:/images/carrot2-clustering-engine.gif")

For the first URL, with the new ReourceHandler, we are able to retrieve the data over the web.
For the second URL, it's a special syntax used by Jawr to retrieve resource for a specific generator.

There is only one class to modify which is CssSyntaxUtils.
I've add in attachement a diff for the change.

Don't hesitate to tell me if something is not clear.

Kind regards,
Ibrahim



Stanisław Osiński added a comment - 22/Sep/09 07:48 AM

Thanks for pointing this out, Ibrahim! I'll merge the diff to the SVN today in the evening.

S.


Stanisław Osiński added a comment - 22/Sep/09 07:53 PM

Thanks for the patch! I've also added a unit test for that, everything is in trunk now. If you'd like to download the binaries, these are here:

http://download.csssprites.org/smartsprites-0.2.5-dev.zip


Ibrahim Chaehoi added a comment - 22/Sep/09 09:07 PM

Hi Staszek,

Thanks for your reactivity

The integration of smartsprites in Jawr is pretty advanced.
I will let you know when we will do our release to be synchronized.

Cheers,
Ibrahim