SmartSprites

Css Attribute parsing : handle url with semi colon

Details

  • Type: Improvement Improvement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.2.4
  • Fix Version/s: 0.2.5
  • Component/s: None
  • Labels:
    None

Description

Hi Staszek,

I've found one issue in the CSS attribute parsing.
Smartsprites can't handle image URL declaration where the is a semi colon in the URL like below :

background-image : url('http://issues.carrot2.org/s/302/1/_/images/carrot2-clustering-engine.gif")
background-image : url('jar:/images/carrot2-clustering-engine.gif")

For the first URL, with the new ReourceHandler, we are able to retrieve the data over the web.
For the second URL, it's a special syntax used by Jawr to retrieve resource for a specific generator.

There is only one class to modify which is CssSyntaxUtils.
I've add in attachement a diff for the change.

Don't hesitate to tell me if something is not clear.

Kind regards,
Ibrahim

Activity

Hide
Stanisław Osiński added a comment -

Thanks for pointing this out, Ibrahim! I'll merge the diff to the SVN today in the evening.

S.

Show
Stanisław Osiński added a comment - Thanks for pointing this out, Ibrahim! I'll merge the diff to the SVN today in the evening. S.
Hide
Stanisław Osiński added a comment -

Thanks for the patch! I've also added a unit test for that, everything is in trunk now. If you'd like to download the binaries, these are here:

http://download.csssprites.org/smartsprites-0.2.5-dev.zip

Show
Stanisław Osiński added a comment - Thanks for the patch! I've also added a unit test for that, everything is in trunk now. If you'd like to download the binaries, these are here: http://download.csssprites.org/smartsprites-0.2.5-dev.zip
Hide
Ibrahim Chaehoi added a comment -

Hi Staszek,

Thanks for your reactivity

The integration of smartsprites in Jawr is pretty advanced.
I will let you know when we will do our release to be synchronized.

Cheers,
Ibrahim

Show
Ibrahim Chaehoi added a comment - Hi Staszek, Thanks for your reactivity The integration of smartsprites in Jawr is pretty advanced. I will let you know when we will do our release to be synchronized. Cheers, Ibrahim

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
2h
Original Estimate - 2h
Remaining:
0h
Remaining Estimate - 0h
Logged:
10m
Time Spent - 10m Time Not Required