Uploaded image for project: 'SmartSprites'
  1. SmartSprites
  2. SMARTSPRITES-48

Refactor error logging and exception handling

    Details

    • Type: Refactoring
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 0.4.0
    • Labels:
      None

      Description

      Currently, there seem to be two patterns for handling exceptions: 1) catch and log a warning, 2) propagate the exception up to the main method.

      The goal of this task is to:

      1. Decide which exceptions are safe to proceed with. These should be logged and not propagated.
      2. Decide which exceptions are fatal. These should be logged and propagated (possibly wrapped in a custom exception type) and should cause SmartSprites to terminate.
      3. Remove throws classes with {{IOException}}s from the call hierarchy, replace with the custom exception type introduced in point 2.
      4. Extend unit test coverage of fatal errors.
      5. Throw a fatal exception in org.carrot2.labs.smartsprites.resource.FileSystemResourceHandler.getResourcePath(String, String) when there is an absolute path to resolve, but document root is not specified.

        Attachments

          Activity

            People

            • Assignee:
              stachoo Stanisław Osiński
              Reporter:
              stachoo Stanisław Osiński
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - 8h
                8h
                Remaining:
                Remaining Estimate - 8h
                8h
                Logged:
                Time Spent - Not Specified
                Not Specified