Uploaded image for project: 'SmartSprites'
  1. SmartSprites
  2. SMARTSPRITES-34

Generated background-image property formatting shouldn't use quotes

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 0.2.3
    • Fix Version/s: 0.3.0
    • Labels:
      None

      Description

      Motivation

      Original report from Jouni:

      Currently the generated CSS format is the following (after processing):

      background-image: url('img/foobar.png');

      Although the format is correct, the single quotes actually break the CSS in some major browsers.

      So the correct format would be this (as valid as the above version, but works in all major browsers):

      background-image: url(img/foobar.png);

      While single quotes in CSS don't break rendering in major browsers, it still may be useful to control the type of quotes used for the generated background-image properties.

      Implementation

      Add an invocation-time parameter called --css-quotes for command line and cssquotes for Ant that will control the type of quotes SmartSprites should use in the generated background-image properties. The parameter will allow three values:

      • SINGLE (default) – use single quote characters (')
      • DOUBLE – use double quote characters (")
      • NONE – use no quotes at all (as suggested by Jouni)

        Attachments

          Activity

            People

            • Assignee:
              stachoo Stanisław Osiński
              Reporter:
              jouni Jouni Koivuviita
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - 2h
                2h
                Remaining:
                Remaining Estimate - 2h
                2h
                Logged:
                Time Spent - Not Specified
                Not Specified