Carrot2

Query parameter is not always set in the request context (DemoBrowser).

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.1
  • Fix Version/s: 2.1
  • Component/s: None
  • Labels:
    None

Description

When the results are retrieved from the cache, the input parameter "query" is not properly set by the input component (because it is bypassed).

Activity

Hide
Dawid Weiss added a comment -

Fixed in trunk. I made a modification to LocalProcessBase to always set the query parameter in the request
context (unless it is already present).

Show
Dawid Weiss added a comment - Fixed in trunk. I made a modification to LocalProcessBase to always set the query parameter in the request context (unless it is already present).
Hide
Stanisław Osiński added a comment -

Not quite fixed in fact Now clustering (cached) local XML files in the tuning browser works kind of weird – when you first load and cluster an XML file you get one set of clusters, and when you just hit the "Refresh" button, you may get a different set of clusters.

This is caused by the fact that the XML file input component changes the query during the processing – on input it gets an XML file name, but if the XML file file contains the original query, the latter is passed down the chain. Unfortunately, with your fix, when replaying from cache, the original query was not restored (and file name was present instead).

I'll commit a fix for that in a second.

Show
Stanisław Osiński added a comment - Not quite fixed in fact Now clustering (cached) local XML files in the tuning browser works kind of weird – when you first load and cluster an XML file you get one set of clusters, and when you just hit the "Refresh" button, you may get a different set of clusters. This is caused by the fact that the XML file input component changes the query during the processing – on input it gets an XML file name, but if the XML file file contains the original query, the latter is passed down the chain. Unfortunately, with your fix, when replaying from cache, the original query was not restored (and file name was present instead). I'll commit a fix for that in a second.
Hide
Stanisław Osiński added a comment -

Fixed in trunk.

Show
Stanisław Osiński added a comment - Fixed in trunk.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: