Carrot2

Attribute binding instantiation exceptions for inaccessible classes.

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 3.4.0
  • Component/s: Framework Core
  • Labels:
    None

Description

As reported on the mailing list, ClusteringDataFromLuceneWithCustomFields does not work due to instantiation exceptions.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dawid Weiss added a comment -

I have patched this in the trunk by setting private classes to accessible, but I'm not sure it's the right way to go – perhaps we should simply fail early with a proper message ("attribute class must be public, not-nested and contain a public parameterless constructor").

Show
Dawid Weiss added a comment - I have patched this in the trunk by setting private classes to accessible, but I'm not sure it's the right way to go – perhaps we should simply fail early with a proper message ("attribute class must be public, not-nested and contain a public parameterless constructor").
Hide
Permalink
Dawid Weiss added a comment -

Leaving for you to decide; my initial gut feeling: revert the patch and throw proper inaccessibility exception.

Show
Dawid Weiss added a comment - Leaving for you to decide; my initial gut feeling: revert the patch and throw proper inaccessibility exception.
Hide
Permalink
Stanisław Osiński added a comment -

+1, let's require the attribute value classes to be public and have a public constructor.

Show
Stanisław Osiński added a comment - +1, let's require the attribute value classes to be public and have a public constructor.
Hide
Permalink
Dawid Weiss added a comment -

In trunk.

Show
Dawid Weiss added a comment - In trunk.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Carrot2. Try JIRA - bug tracking software for your team.