History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: CARROT-387
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Dawid Weiss
Reporter: Dawid Weiss
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Carrot2

Workbench does not open -- class not found from OpenSearch component

Created: 21/Sep/08 02:28 PM   Updated: 21/Sep/08 10:20 PM
Component/s: Framework Core
Affects Version/s: None
Fix Version/s: 3.0

Time Tracking:
Not Specified


 Description  « Hide
Workbench fails to load the open search component because it declares JAR dependencies on Rome. This is quite strange and may be related with dynamic class creation mechanism we have. I will investigate in the afternoon today.

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Dawid Weiss - 21/Sep/08 09:33 PM
I know what the problem is – we instantiate classes using reflection from plugins that have no direct relationship with the plugin these instantiated classes come from. This causes, as one side-effect, class not found exceptions for any class that is visible only from the target plugin. If this sounds vague that's because it is.

Anyway, I do have at least two different workarounds in my head
1) extract plugin JARs to separate plugins and re-export them,
2) add very specific buddy policy between sources/ algorithms and core/attribute plugins.

Will work on these.


Dawid Weiss - 21/Sep/08 10:20 PM
Definitely the cause of our problems is the fact that we're using Java reflection to instantiate component instances. The extension (factory) model we previously had, in spite of the duplication it provided in addition to suite definitions, was more flexible and aligned well with the OSGi model. Extension implementations reside inside their defining plugin and since so have access to all of that plugin's resources (classes).

Let's stick to the suite definition model for now though. Consistency between the webapp, DCS and workbench is worth it.


Dawid Weiss - 21/Sep/08 10:20 PM
Fixed in trunk.